feat: use native metrics-server chart #2514
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasLubbers
requested review from
j-zimnowoda,
merll and
Ani1357
as code owners
j-zimnowoda
reviewed
Sep 12, 2025
| {{- end }} | ||
|
|
||
| extraArgs: | ||
| - --kubelet-preferred-address-types=InternalIP |
There was a problem hiding this comment.
Why this argument is not valid anymore?
There was a problem hiding this comment.
Its already in the default args:
defaultArgs:
- --cert-dir=/tmp
- --kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname
- --kubelet-use-node-status-port
- --metric-resolution=15s
And it needs to be set like this otherwise there are errors in the metrics-server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
NOTE: Does not work with ORCS yet!
Updated metrics-server chat with the one at: https://artifacthub.io/packages/helm/metrics-server/metrics-server
Removed arg that was already in chart.
Updated chart-index
🔍 Reviewer Notes
🧹 Checklist