Skip to content

fix: fix batch inserts for large project imports #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yyg-max merged 2 commits into from
Nov 4, 2025
Merged

fix: fix batch inserts for large project imports #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39d72a7
fix: fix batch inserts for large project imports
TethysPlex Nov 1, 2025
ebdd350
refactor: 移动 projectItemInsertBatchSize 常量
TethysPlex Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/apps/project/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ package project

const (
ProjectObjKey = "project_obj"
// projectItemInsertBatchSize limits batch inserts to avoid exceeding MySQL's placeholder ceiling.
projectItemInsertBatchSize = 1000
)

type DistributionType int8
Expand Down
4 changes: 2 additions & 2 deletions internal/apps/project/models.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ func (p *Project) CreateItems(ctx context.Context, tx *gorm.DB, items []string,
projectItems[i] = wi.item
}

if err := tx.Create(&projectItems).Error; err != nil {
if err := tx.CreateInBatches(&projectItems, projectItemInsertBatchSize).Error; err != nil {
return err
}

Expand All @@ -259,7 +259,7 @@ func (p *Project) CreateItems(ctx context.Context, tx *gorm.DB, items []string,
projectItems[i] = ProjectItem{ProjectID: p.ID, Content: content}
}

if err := tx.Create(&projectItems).Error; err != nil {
if err := tx.CreateInBatches(&projectItems, projectItemInsertBatchSize).Error; err != nil {
return err
}

Expand Down