-
Notifications
You must be signed in to change notification settings - Fork 19
feat: add Qt5 and Qt6 dual version support #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
db3ffb2 to
d888c2f
Compare
1. Added automatic Qt version detection in CMakeLists.txt to support both Qt5 and Qt6 2. Modified CMake configuration to use dynamic Qt version variables instead of hardcoded Qt6 3. Updated debian/control to include Qt5 package alternatives for build dependencies 4. Enhanced debian/rules to detect available Qt version and set appropriate QT_DIR 5. This change allows the project to build on systems with either Qt5 or Qt6 installed Log: Added support for both Qt5 and Qt6 versions Influence: 1. Test building on systems with only Qt5 installed 2. Test building on systems with only Qt6 installed 3. Verify application functionality on both Qt5 and Qt6 environments 4. Check that all UI components render correctly in both versions 5. Test device formatting functionality remains consistent across Qt versions feat: 添加 Qt5 和 Qt6 双版本支持 1. 在 CMakeLists.txt 中添加自动 Qt 版本检测,支持 Qt5 和 Qt6 2. 修改 CMake 配置使用动态 Qt 版本变量替代硬编码的 Qt6 3. 更新 debian/control 包含 Qt5 包替代方案用于构建依赖 4. 增强 debian/rules 以检测可用 Qt 版本并设置合适的 QT_DIR 5. 此更改允许项目在安装 Qt5 或 Qt6 的系统上构建 Log: 新增对 Qt5 和 Qt6 双版本的支持 Influence: 1. 在仅安装 Qt5 的系统上测试构建 2. 在仅安装 Qt6 的系统上测试构建 3. 验证应用在 Qt5 和 Qt6 环境下的功能 4. 检查所有 UI 组件在两个版本中是否正确渲染 5. 测试设备格式化功能在 Qt 版本间保持一致 TASK: https://pms.uniontech.com/task-view-383509.html
deepin pr auto review我来对这个diff进行代码审查,主要从以下几个方面分析:
总结:
这些改进建议都是可选的,当前代码已经能够正常工作且具有良好的可维护性。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kakueeen, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
both Qt5 and Qt6
instead of hardcoded Qt6
dependencies
appropriate QT_DIR
Qt6 installed
Log: Added support for both Qt5 and Qt6 versions
Influence:
versions
feat: 添加 Qt5 和 Qt6 双版本支持
Log: 新增对 Qt5 和 Qt6 双版本的支持
Influence:
TASK: https://pms.uniontech.com/task-view-383509.html