-
Notifications
You must be signed in to change notification settings - Fork 55
fix: add missing definitions for dockpanel #1309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ComixHe <heyuming@deepin.org>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR enriches DockPanel by declaring an overload for geometry retrieval with offset parameters and adding an invokable method to broadcast dock position changes via D-Bus. Class diagram for updated DockPanel methodsclassDiagram
class DockPanel {
+QRect geometry()
+QRect frontendWindowRect()
+QRect frontendWindowRect(int transformOffsetX, int transformOffsetY)
+HideState hideState()
+void openDockSettings() const
+void notifyDockPositionChanged(int offsetX, int offsetY)
+bool showInPrimary() const
+void setShowInPrimary(bool newShowInPrimary)
}
DockPanel --|> DPanel
DockPanel --|> QDBusContext
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, ComixHe The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Summary by Sourcery
Declare missing methods in the DockPanel interface to fix compilation and enable notifications for dock position and transformed window geometry.
Bug Fixes: