Skip to content

Conversation

@ComixHe
Copy link
Contributor

@ComixHe ComixHe commented Oct 22, 2025

Summary by Sourcery

Declare missing methods in the DockPanel interface to fix compilation and enable notifications for dock position and transformed window geometry.

Bug Fixes:

  • Add overload for frontendWindowRect with transformOffsetX and transformOffsetY parameters.
  • Add Q_INVOKABLE notifyDockPositionChanged to propagate dock position updates.

Signed-off-by: ComixHe <heyuming@deepin.org>
@ComixHe ComixHe requested a review from 18202781743 October 22, 2025 05:52
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 22, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enriches DockPanel by declaring an overload for geometry retrieval with offset parameters and adding an invokable method to broadcast dock position changes via D-Bus.

Class diagram for updated DockPanel methods

classDiagram
class DockPanel {
  +QRect geometry()
  +QRect frontendWindowRect()
  +QRect frontendWindowRect(int transformOffsetX, int transformOffsetY)
  +HideState hideState()
  +void openDockSettings() const
  +void notifyDockPositionChanged(int offsetX, int offsetY)
  +bool showInPrimary() const
  +void setShowInPrimary(bool newShowInPrimary)
}
DockPanel --|> DPanel
DockPanel --|> QDBusContext
Loading

File-Level Changes

Change Details Files
Introduce offset-aware geometry retrieval
  • Added frontendWindowRect(int transformOffsetX, int transformOffsetY) declaration
panels/dock/dockpanel.h
Enable dock position change notifications
  • Added Q_INVOKABLE notifyDockPositionChanged(int offsetX, int offsetY) declaration
panels/dock/dockpanel.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, ComixHe

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743
Copy link
Contributor

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Oct 22, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit b905df4 into linuxdeepin:master Oct 22, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants