-
Notifications
You must be signed in to change notification settings - Fork 55
feat: add modal property to notification setting menu #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR sets the NotifySettingMenu component to modal, preventing background interactions and aligning its behavior with other modal dialogs for a focused user experience. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1. Set modal property to true for NotifySettingMenu 2. This prevents interaction with other UI elements while menu is open 3. Improves user experience by focusing attention on the menu 4. Ensures menu behavior is consistent with other modal dialogs feat: 为通知设置菜单添加模态属性 1. 将 NotifySettingMenu 的 modal 属性设置为 true 2. 防止菜单打开时与其他 UI 元素交互 3. 通过将注意力集中在菜单上来改善用户体验 4. 确保菜单行为与其他模态对话框保持一致 PMS: BUG-299885
8b8947c to
83cfdc9
Compare
deepin pr auto review我来对这段代码变更进行审查:
改进建议:
修改后的建议代码: Menu {
id: root
closePolicy: Popup.CloseOnPressOutside | Popup.CloseOnEscape
// 设置为模态对话框,确保用户完成菜单操作前无法与其他界面交互
modal: true
function toggle()
{总体来说,这是一个简单有效的修改,但建议添加适当的注释来说明设计意图。 |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
feat: 为通知设置菜单添加模态属性
PMS: BUG-299885
Summary by Sourcery
New Features: