-
Notifications
You must be signed in to change notification settings - Fork 55
feat: add camera status OSD notifications #1321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideIntroduces camera status OSD notifications by adding new icon assets and extending the OSD notification panel with CameraOn/CameraOff entries including translated text. Class diagram for updated OSD notification typesclassDiagram
class NotificationType {
+type: String
+iconName: String
+text: String
}
NotificationType <|-- CameraOn
NotificationType <|-- CameraOff
class CameraOn {
+type = "CameraOn"
+iconName = "osd_camera_on"
+text = "Camera on"
}
class CameraOff {
+type = "CameraOff"
+iconName = "osd_camera_off"
+text = "Camera off"
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Ensure that your notification backend emits the exact type strings “CameraOn” and “CameraOff” so these new ListElements are actually triggered.
- Don’t forget to add qsTr translations for “Camera on” and “Camera off” to your .po files so the new notifications are localized correctly.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure that your notification backend emits the exact type strings “CameraOn” and “CameraOff” so these new ListElements are actually triggered.
- Don’t forget to add qsTr translations for “Camera on” and “Camera off” to your .po files so the new notifications are localized correctly.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Added camera status OSD (On-Screen Display) notifications to the notification panel 1. Added two new icon files: osd_camera_on.dci and osd_camera_off.dci for camera status indicators 2. Updated main.qml to include new notification types for camera on/ off states 3. Added ListElement entries for CameraOn and CameraOff types with corresponding icons and translated text This enhancement provides visual feedback to users when their camera is turned on or off, improving the user experience for camera-related operations Log: Added camera status notifications in OSD panel Influence: 1. Test camera on/off notifications appear in OSD when camera state changes 2. Verify camera on icon (osd_camera_on) displays correctly 3. Verify camera off icon (osd_camera_off) displays correctly 4. Check notification text is properly translated in different languages 5. Ensure notifications integrate properly with existing OSD notification system feat: 添加摄像头状态 OSD 通知 在通知面板中添加摄像头状态 OSD(屏幕显示)通知功能 1. 新增两个图标文件:osd_camera_on.dci 和 osd_camera_off.dci 用于摄像头 状态指示 2. 更新 main.qml 文件,添加摄像头开关状态的新通知类型 3. 添加 CameraOn 和 CameraOff 类型的 ListElement 条目,包含对应图标和翻 译文本 此增强功能在用户摄像头开启或关闭时提供视觉反馈,改善摄像头相关操作用户 体验 Log: 在 OSD 面板中添加摄像头状态通知 Influence: 1. 测试摄像头状态变化时 OSD 中是否显示开关通知 2. 验证摄像头开启图标(osd_camera_on)正确显示 3. 验证摄像头关闭图标(osd_camera_off)正确显示 4. 检查通知文本在不同语言环境下是否正确翻译 5. 确保通知与现有 OSD 通知系统正确集成 PMS: BUG-338439
deepin pr auto review我来对这个 git diff 进行代码审查:
改进建议:
总结: |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Added camera status OSD (On-Screen Display) notifications to the
notification panel
for camera status indicators
off states
corresponding icons and translated text
This enhancement provides visual feedback to users when their camera
is turned on or off, improving the user experience for camera-related
operations
Log: Added camera status notifications in OSD panel
Influence:
changes
notification system
feat: 添加摄像头状态 OSD 通知
在通知面板中添加摄像头状态 OSD(屏幕显示)通知功能
状态指示
译文本
此增强功能在用户摄像头开启或关闭时提供视觉反馈,改善摄像头相关操作用户
体验
Log: 在 OSD 面板中添加摄像头状态通知
Influence:
PMS: BUG-338439
Summary by Sourcery
New Features: