fix: Fix error in obtaining resident app status

[pengfeixx]

Fix error in obtaining resident app status

Log: Fix error in obtaining resident app status
pms: BUG-343145

Summary by Sourcery

Bug Fixes:

• Resolve incorrect resident/docked app status caused by failing to obtain or validate the AppItem object before checking its docked state.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors docked-status retrieval in TaskManager to query the desktop file parser directly for resident app status, avoiding potential null QPointer access and aligning with the parser’s API.

Sequence diagram for updated docked-status retrieval in TaskManager::IsDocked

sequenceDiagram
    participant TaskManager
    participant DesktopFileParser

    TaskManager->>DesktopFileParser: isDocked(appID)
    DesktopFileParser-->>TaskManager: bool isDocked

    Note over TaskManager,DesktopFileParser: QPointer<AppItem> and AppItem::isDocked are no longer used directly

Loading

Updated class diagram for docked-status retrieval in TaskManager

classDiagram
    class TaskManager {
        +bool IsDocked(QString appID)
        +bool RequestUndock(QString appID)
    }

    class DesktopFileParser {
        +bool isDocked()
        +QPointer~AppItem~ getAppItem()
    }

    class AppItem {
        +bool isDocked()
    }

    TaskManager --> DesktopFileParser : uses
    DesktopFileParser --> AppItem : provides

    %% Change: TaskManager::IsDocked now calls DesktopFileParser::isDocked directly
    %% instead of retrieving AppItem via getAppItem and calling AppItem::isDocked

Loading

File-Level Changes

Change	Details	Files
Use DesktopfileParser’s docked-status query directly instead of going through AppItem, eliminating null-pointer handling in IsDocked.	Replace creation of a QPointer via getAppItem() with a direct call to desktopfileParser->isDocked(). Remove explicit null check and early return based on the AppItem pointer, relying on DesktopfileParser to handle missing or invalid app data. Keep IsDocked’s early return when the desktopfileParser is invalid, preserving existing safety checks.	panels/dock/taskmanager/taskmanager.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

这段代码变更看起来是一个重构优化，我来详细分析一下：

1. 代码逻辑改进：

• 原代码通过 desktopfileParser->getAppItem() 获取 AppItem 指针，然后检查是否为空，最后调用 isDocked() 方法
• 新代码直接调用 desktopfileParser->isDocked()，简化了调用链
• 这是一个很好的封装改进，将内部实现细节隐藏在 DesktopFileParser 类中

2. 代码质量提升：

• 减少了中间变量 QPointer 的使用，降低了代码复杂度
• 代码更加简洁，从 5 行减少到 1 行
• 降低了出错的可能性，因为减少了空指针检查的需要

3. 性能优化：

• 减少了不必要的指针操作和空值检查
• 减少了函数调用层次，可能带来轻微的性能提升

4. 安全性考虑：

• 原代码中的空指针检查虽然必要，但增加了代码复杂度
• 新代码将这个检查逻辑封装在 DesktopFileParser::isDocked() 中，更符合面向对象设计原则

建议：

1. 确保 DesktopFileParser::isDocked() 方法内部已经正确处理了空指针情况
2. 建议在 DesktopFileParser 类的文档中明确说明 isDocked() 方法的返回值含义
3. 可以考虑添加单元测试来验证这个重构是否改变了原有的行为

总的来说，这是一个很好的重构，提高了代码的可维护性和可读性，同时保持了相同的功能。

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Given the previous null check on getAppItem(), ensure that DesktopfileParser::isDocked() gracefully handles cases where the underlying app item or metadata is missing or invalid so that behavior remains consistent (e.g., returning false instead of crashing or throwing).

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Given the previous null check on `getAppItem()`, ensure that `DesktopfileParser::isDocked()` gracefully handles cases where the underlying app item or metadata is missing or invalid so that behavior remains consistent (e.g., returning `false` instead of crashing or throwing).

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, pengfeixx

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment