Skip to content

Conversation

@18202781743
Copy link
Contributor

as title.

@18202781743
Copy link
Contributor Author

@xionglinlin

xionglinlin
xionglinlin previously approved these changes Nov 23, 2024
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • treelandlockscreen.cpp文件中,workder函数拼写错误,应为worker
  • treelandlockscreen.cpp文件中的shutdown函数和switchUser函数缺少对impl指针的空指针检查。
  • treelandlockscreen.cpp文件中的shutdown函数和switchUser函数可能需要异常处理机制,以防止在调用impl时发生错误。
  • treelandlockscreen.h文件中的TreeLandLockScreen类缺少对lock函数的注释说明。
  • treelandlockscreen.h文件中的TreeLandLockScreenWorker类缺少对lock函数的注释说明。
  • lockscreen-example/package/main.qml文件中的lockscreenApplet函数缺少对DS.applet返回值的空指针检查。
  • lockscreen-example/package/main.qml文件中的lockscreenApplet函数可能需要异常处理机制,以防止在调用DS.applet时发生错误。

是否建议立即修改:

@18202781743
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Nov 26, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit bdc00f9 into linuxdeepin:master Nov 26, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants