Skip to content

Conversation

@tsic404
Copy link
Contributor

@tsic404 tsic404 commented Nov 26, 2024

we find transientParent from current to toppest

log: as title

@tsic404 tsic404 force-pushed the panel/dock/not-hidden branch from c7a918d to 1079870 Compare November 26, 2024 08:41
we find transientParent from current to toppest

log: as title
@tsic404 tsic404 force-pushed the panel/dock/not-hidden branch from 1079870 to dbb33b3 Compare November 26, 2024 08:46
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码中新增了一个变量 topTransientParent 来跟踪窗口的顶层瞬态父对象,这是一个合理的改进,有助于提高代码的可读性和可维护性。
  • 修改了条件判断中的 window->transientParent()topTransientParent,这确保了条件判断的逻辑正确性。

是否建议立即修改:

  • 否,提交的代码没有明显的语法错误或逻辑问题。
  • 是,建议进行进一步的代码审查,以确保没有遗漏的边界情况,并且代码风格与项目规范一致。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, tsic404

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsic404
Copy link
Contributor Author

tsic404 commented Nov 27, 2024

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Nov 27, 2024

This pr force merged! (status: behind)

@deepin-bot deepin-bot bot merged commit 0bbd96b into linuxdeepin:master Nov 27, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants