fix: popup can not auto hide on treeland #915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinshark
previously approved these changes
Nov 29, 2024
18202781743
reviewed
Nov 29, 2024
tsic404
force-pushed
the
focus
branch
2 times, most recently
from
034b761 to
93399ac
Compare
|
TAG Bot TAG: 1.99.8 |
yixinshark
previously approved these changes
Nov 29, 2024
tsic404
force-pushed
the
focus
branch
2 times, most recently
from
f563c99 to
6ddeb6a
Compare
18202781743
reviewed
Nov 29, 2024
Qt popup get event from other window, so it's necessary to make dock can get focus. And add a PopupWindow to handle Popup auto hide. log: as title
log: as title
deepin pr auto review代码审查意见：
总体来说，代码的修改看起来是为了修复一个弹出窗口无法隐藏的问题，但是需要确保所有的修改都是必要的，并且没有引入新的问题。同时，应该添加更多的注释来解释代码的意图和功能，以提高代码的可读性和可维护性。 |
yixinshark
approved these changes
Nov 29, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tsic404, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt popup get event from other window, so it's necessary to make dock can get focus. And add a PopupWindow to handle Popup auto hide.
log: as title