Skip to content

Conversation

@BLumia
Copy link
Member

@BLumia BLumia commented Nov 30, 2024

修复部分场景下可能导致错误识别 desktopId,导致任务栏图标被隐藏.

Log:

修复部分场景下可能导致错误识别 desktopId,导致任务栏图标被隐藏.

Log:
@BLumia BLumia requested a review from tsic404 November 30, 2024 03:48
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码中存在多次重复调用 res.first().data(m_activeAppModel->roleNames().key("desktopId")).toString(),建议提取为变量以减少重复代码。
  • DESKTOPFILEFACTORY::createById 方法被调用两次,一次是 amAPP,一次是 asbtractAPP,可能需要确认这两个参数是否正确。
  • desktopfile->isValied().first 应该是 desktopfile->isValid().first,拼写错误可能会导致逻辑错误。
  • desktopfile.isNull() 检查后直接调用 DESKTOPFILEFACTORY::createByWindow(window),可能需要考虑 desktopfile.isNull()true 时的处理逻辑。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 735c434 into linuxdeepin:master Nov 30, 2024
7 of 10 checks passed
@BLumia BLumia deleted the empty-icon branch November 30, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants