Skip to content

Conversation

@yixinshark
Copy link
Contributor

…after new notifications are added.

as title

Log: as title
Bug: https://pms.uniontech.com/bug-view-290209.html

@yixinshark yixinshark force-pushed the fix-displayOldBubbles branch from 43fa6d3 to cf97062 Compare November 30, 2024 07:36
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark force-pushed the fix-displayOldBubbles branch from cf97062 to 9db02fb Compare December 2, 2024 05:51
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • setBubbleCount函数中,beginRemoveRowsbeginInsertRows的调用没有检查m_bubbles的大小,可能会导致越界访问。
  • updateLevel函数被调用时没有检查BubbleMaxCount是否已经更新,可能会导致不一致的状态。

是否建议立即修改:

@yixinshark
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Dec 2, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 7eb440c into linuxdeepin:master Dec 2, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants