chore: TrayLoader single process support to start multiple plugins #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinshark
force-pushed
the
chore-trayLoaderLoadMultPlugins
branch
2 times, most recently
from
b491876 to
5b413b0
Compare
yixinshark
force-pushed
the
chore-trayLoaderLoadMultPlugins
branch
from
5b413b0 to
54c2e6b
Compare
tsic404
reviewed
Dec 4, 2024
| "name[zh_CN]": "自维护托盘插件", | ||
| "description": "self maintenance plugins", | ||
| "description[zh_CN]": "自维护托盘插件", | ||
| "permissions": "readwrite", |
tsic404
reviewed
Dec 4, 2024
| "serial": 0, | ||
| "flags": [], | ||
| "name": "application tray plugins", | ||
| "name[zh_CN]": "应用托盘插件", |
tsic404
reviewed
Dec 4, 2024
| "name[zh_CN]": "应用托盘插件", | ||
| "description": "application tray plugins", | ||
| "description[zh_CN]": "应用托盘插件", | ||
| "permissions": "readwrite", |
18202781743
reviewed
Dec 4, 2024
panels/dock/loadtrayplugins.cpp
Outdated
| if (dirs.isEmpty()) | ||
| dirs << pluginDirs; | ||
|
|
||
| QString selfMaintenancePluginPaths; |
Contributor
There was a problem hiding this comment.
可以声明为一个list, 用join(";")去拼接成一个字符串。
18202781743
reviewed
Dec 4, 2024
| "permissions": "readwrite", | ||
| "visibility": "private" | ||
| }, | ||
| "selfMaintenanceTrayPlugins": { |
Contributor
There was a problem hiding this comment.
我们自己维护的插件，能不能改插件类型，在meta中加个字段，
yixinshark
force-pushed
the
chore-trayLoaderLoadMultPlugins
branch
2 times, most recently
from
ded970b to
0ea3291
Compare
tsic404
reviewed
Dec 4, 2024
panels/dock/loadtrayplugins.cpp
Outdated
| const QString otherPlugins = "otherPlugins"; | ||
|
|
||
| auto dConfig = Dtk::Core::DConfig::create("org.deepin.dde.shell", "org.deepin.ds.dock.tray", QString()); | ||
| QStringList selfMaintenanceTrayPlugins = dConfig->value("selfMaintenanceTrayPlugins").toStringList(); |
tsic404
reviewed
Dec 4, 2024
| for (auto &pluginDir : dirs) { | ||
| QDir dir(pluginDir); | ||
| if (!dir.exists()) { | ||
| qWarning() << "The plugin directory does not exist:" << pluginDir; |
18202781743
reviewed
Dec 5, 2024
panels/dock/loadtrayplugins.cpp
Outdated
| return validExePath; | ||
| } | ||
|
|
||
| QMap<QString, QString> LoadTrayPlugins::getPluginGroup() const |
Contributor
There was a problem hiding this comment.
要不抽出一个函数吧，传入满足的条件，返回结果，例如QStringList xxx(const QStringList &plugins) const;
Contributor
Author
There was a problem hiding this comment.
抽一个获取所有插件的函数，和给插件分组的函数。
yixinshark
force-pushed
the
chore-trayLoaderLoadMultPlugins
branch
3 times, most recently
from
254a5af to
cf9a3b2
Compare
tsic404
approved these changes
Dec 6, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tsic404, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
yixinshark
force-pushed
the
chore-trayLoaderLoadMultPlugins
branch
from
cf9a3b2 to
f46b80a
Compare
1.Divide plugins into three groups(selfMaintenance,application,other) 2.single process support to start multiple plugins Log: as title Bug: https://pms.uniontech.com/bug-view-283901.html
yixinshark
force-pushed
the
chore-trayLoaderLoadMultPlugins
branch
from
f46b80a to
0910903
Compare
deepin pr auto review代码审查意见：
总体来说，代码重构和错误处理是这次提交的主要改进点，但还需要注意依赖项的兼容性、配置文件的处理、资源管理和安全性等方面的问题。 |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Divide plugins into three groups(selfMaintenance,application,other) 2.single process support to start multiple plugins
Log: as title
Bug: https://pms.uniontech.com/bug-view-283901.html