-
Notifications
You must be signed in to change notification settings - Fork 45
fix: remove deprecated Boost.System component from CMake #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @hillwoodroc. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates CMake configuration to stop requesting the deprecated Boost.System component and instead rely on header-only Boost, ensuring compatibility with newer Boost versions while also fixing a minor formatting issue. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@hillwoodroc 你好, 目前该代码需要支持低版本的 boost (1.67), 看如何增加下兼容性 |
a0ef73a to
b878211
Compare
更新了 patch,保留了对旧版 boost 的支持。 |
使用 Boost_VERSION 与版本字符串比较不起作用, 可以考虑使用 Boost_VERSION_STRING 或者版本整数 |
b878211 to
6de7e7b
Compare
更新提交,用 Boost_VERSION_STRING 代替。版本整数似乎在 1.89 上有问题。 |
Boost.System is header-only in newer Boost versions (e.g. 1.89) and no longer provides boost_systemConfig.cmake or libboost_system. Keeping `find_package(Boost COMPONENTS system)` causes configuration errors because the component no longer exists. Switching to a plain `find_package(Boost REQUIRED)` restores compatibility and works on all modern Boost installations. Log: This fix updates both daemon and searcher CMakeLists accordingly. And keep support for old boost
6de7e7b to
85273e3
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hillwoodroc, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Boost.System is header-only in newer Boost versions (e.g. 1.89) and no longer provides boost_systemConfig.cmake or libboost_system.
Keeping
find_package(Boost COMPONENTS system)causes configuration errors because the component no longer exists. Switching to a plainfind_package(Boost REQUIRED)restores compatibility and works on all modern Boost installations.Log: This fix updates both daemon and searcher CMakeLists accordingly. Also fixes missing newline at end of file in searcher CMakeLists.txt.
Summary by Sourcery
Update CMake Boost discovery to avoid requiring the deprecated Boost.System component.
Build:
Boost COMPONENTS systemto a genericBoost REQUIREDin daemon and searcher targets to support newer header-only Boost.System.