Skip to content

Conversation

@hillwoodroc
Copy link
Contributor

@hillwoodroc hillwoodroc commented Dec 6, 2025

Boost.System is header-only in newer Boost versions (e.g. 1.89) and no longer provides boost_systemConfig.cmake or libboost_system.

Keeping find_package(Boost COMPONENTS system) causes configuration errors because the component no longer exists. Switching to a plain find_package(Boost REQUIRED) restores compatibility and works on all modern Boost installations.

Log: This fix updates both daemon and searcher CMakeLists accordingly. Also fixes missing newline at end of file in searcher CMakeLists.txt.

Summary by Sourcery

Update CMake Boost discovery to avoid requiring the deprecated Boost.System component.

Build:

  • Relax Boost CMake dependency from Boost COMPONENTS system to a generic Boost REQUIRED in daemon and searcher targets to support newer header-only Boost.System.
  • Fix formatting by ensuring the searcher CMakeLists.txt ends with a newline.

@deepin-ci-robot
Copy link

Hi @hillwoodroc. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 6, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates CMake configuration to stop requesting the deprecated Boost.System component and instead rely on header-only Boost, ensuring compatibility with newer Boost versions while also fixing a minor formatting issue.

File-Level Changes

Change Details Files
Update Boost discovery in CMake to no longer require the deprecated Boost.System component, ensuring compatibility with newer Boost versions.
  • Replace find_package(Boost REQUIRED COMPONENTS system) with find_package(Boost REQUIRED) in the searcher target CMake configuration.
  • Replace find_package(Boost REQUIRED COMPONENTS system) with find_package(Boost REQUIRED) in the daemon CMake configuration.
src/searcher/CMakeLists.txt
src/daemon/CMakeLists.txt
Fix minor formatting issue in searcher CMake configuration.
  • Add the missing newline at the end of the searcher CMakeLists.txt file.
src/searcher/CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@wangrong1069
Copy link
Contributor

@hillwoodroc 你好, 目前该代码需要支持低版本的 boost (1.67), 看如何增加下兼容性
如 find_package(Boost OPTIONAL_COMPONENTS system)

@hillwoodroc
Copy link
Contributor Author

hillwoodroc commented Dec 10, 2025

@hillwoodroc 你好, 目前该代码需要支持低版本的 boost (1.67), 看如何增加下兼容性 如 find_package(Boost OPTIONAL_COMPONENTS system)

更新了 patch,保留了对旧版 boost 的支持。

@wangrong1069
Copy link
Contributor

@hillwoodroc 你好, 目前该代码需要支持低版本的 boost (1.67), 看如何增加下兼容性 如 find_package(Boost OPTIONAL_COMPONENTS system)

更新了 patch,保留了对旧版 boost 的支持。

使用 Boost_VERSION 与版本字符串比较不起作用, 可以考虑使用 Boost_VERSION_STRING 或者版本整数

@hillwoodroc
Copy link
Contributor Author

hillwoodroc commented Dec 11, 2025

@hillwoodroc 你好, 目前该代码需要支持低版本的 boost (1.67), 看如何增加下兼容性 如 find_package(Boost OPTIONAL_COMPONENTS system)

更新了 patch,保留了对旧版 boost 的支持。

使用 Boost_VERSION 与版本字符串比较不起作用, 可以考虑使用 Boost_VERSION_STRING 或者版本整数

更新提交,用 Boost_VERSION_STRING 代替。版本整数似乎在 1.89 上有问题。

Boost.System is header-only in newer Boost versions (e.g. 1.89) and
no longer provides boost_systemConfig.cmake or libboost_system.

Keeping `find_package(Boost COMPONENTS system)` causes configuration
errors because the component no longer exists. Switching to a plain
`find_package(Boost REQUIRED)` restores compatibility and works on
all modern Boost installations.

Log: This fix updates both daemon and searcher CMakeLists accordingly.
And keep support for old boost
@lzwind lzwind merged commit 097d3f5 into linuxdeepin:develop/snipe Dec 11, 2025
17 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hillwoodroc, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants