-
Notifications
You must be signed in to change notification settings - Fork 45
fix: Fix sw64 gcc not support pie by default #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add the -fPIE parameter via CMAKE_POSITION_INDEPENDENT_CODE. Add the -pie parameter via target_link_options. Log: Update compiler flags for security enhancements Bug: https://pms.uniontech.com/bug-view-339563.html
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnables position-independent code globally and links all main executables with PIE on sw64 by setting CMake’s global PIC flag and adding -pie link options to core targets. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Enabling
CMAKE_POSITION_INDEPENDENT_CODEglobally may affect all targets (including shared libraries); consider restricting this to the specific executables or to the sw64 toolchain via appropriate CMake conditionals. - The use of
target_link_optionsrequires a newer CMake version than the currentcmake_minimum_required(VERSION 3.1.0); either bump the minimum required version or gate this behind a version check and use a fallback for older CMake. - The
-pielink option is added unconditionally; consider applying it only when using GCC on sw64 (or when the compiler/linker supports PIE) to avoid build issues on other platforms/toolchains.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Enabling `CMAKE_POSITION_INDEPENDENT_CODE` globally may affect all targets (including shared libraries); consider restricting this to the specific executables or to the sw64 toolchain via appropriate CMake conditionals.
- The use of `target_link_options` requires a newer CMake version than the current `cmake_minimum_required(VERSION 3.1.0)`; either bump the minimum required version or gate this behind a version check and use a fallback for older CMake.
- The `-pie` link option is added unconditionally; consider applying it only when using GCC on sw64 (or when the compiler/linker supports PIE) to avoid build issues on other platforms/toolchains.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, wangrong1069 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/merge |
Add the -fPIE parameter via CMAKE_POSITION_INDEPENDENT_CODE. Add the -pie parameter via target_link_options.
Log: Update compiler flags for security enhancements
Bug: https://pms.uniontech.com/bug-view-339563.html
Summary by Sourcery
Enable position-independent code and PIE linking for all targets to address sw64 GCC default PIE support issues.
Build: