fix: don't ignore linker flags specified by system #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: REUSE Compliance Check failedDetails# MISSING COPYRIGHT AND LICENSING INFORMATIONThe following files have no copyright and licensing information:
The following files have no licensing information:
SUMMARY
Unfortunately, your project is not compliant with version 3.0 of the REUSE Specification :-( |
|
missing README.zh_CN.md |
|
/check |
Contributor
|
Deepin Obs Bot |
|
Hello, because this PR is a little different from the latest code, please update this PR or re-submit PR. |
Contributor
|
TAG Bot New tag: 6.0.1 |
Contributor
|
TAG Bot New tag: 6.0.2 |
Contributor
|
TAG Bot New tag: 6.5.0 |
Contributor
|
TAG Bot New tag: 6.5.1 |
Contributor
|
TAG Bot New tag: 6.5.2 |
Contributor
|
TAG Bot New tag: 6.5.3 |
Contributor
|
TAG Bot New tag: 6.5.4 |
Make use of CMAKE_EXE_LINKER_FLAGS Log: Don't ignore linker flags specified by system
Member
Author
Rebased now. |
Contributor
|
TAG Bot New tag: 6.5.5 |
Contributor
|
TAG Bot New tag: 6.5.6 |
Contributor
|
TAG Bot New tag: 6.5.7 |
Contributor
|
TAG Bot New tag: 6.5.8 |
Contributor
|
TAG Bot New tag: 6.5.9 |
Contributor
|
TAG Bot New tag: 6.5.10 |
Contributor
|
TAG Bot New tag: 6.5.11 |
Contributor
|
TAG Bot New tag: 6.5.12 |
Contributor
|
TAG Bot New tag: 6.5.13 |
Contributor
|
TAG Bot New tag: 6.5.14 |
Contributor
|
TAG Bot New tag: 6.5.15 |
Contributor
|
TAG Bot New tag: 6.5.16 |
Contributor
|
TAG Bot New tag: 6.5.17 |
Contributor
|
TAG Bot New tag: 6.5.18 |
Contributor
|
TAG Bot New tag: 6.5.19 |
Contributor
|
TAG Bot New tag: 6.5.20 |
Contributor
|
TAG Bot New tag: 6.5.21 |
Contributor
|
TAG Bot New tag: 6.5.22 |
Contributor
|
TAG Bot New tag: 6.5.23 |
Contributor
|
TAG Bot New tag: 6.5.24 |
Contributor
|
TAG Bot New tag: 6.5.25 |
qaqland
approved these changes
Sep 4, 2025
deepin pr auto review这段diff修改了CMakeLists.txt中的CMAKE_EXE_LINKER_FLAGS设置，我来分析一下这个修改：
改进建议：
例如，可以这样改进： # Security flags
set(SECURITY_LINKER_FLAGS "-pie -Wl,-z,relro,-z,now")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${SECURITY_LINKER_FLAGS}")这样的修改既保持了原有功能，又提高了代码的可维护性和安全性。 |
BLumia
approved these changes
Sep 4, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, felixonmars, qaqland The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of CMAKE_EXE_LINKER_FLAGS
Log: Don't ignore linker flags specified by system