-
Notifications
You must be signed in to change notification settings - Fork 40
fix: Improve supported resolution detection for display devices #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed refresh rate errors and spelling mistakes in Device Manager → Display → Supported Resolutions. Now accurately obtains resolutions from xrandr output (keeping only integer values) instead of potentially problematic hwinfo detection. Log: Fix display resolution detection method Bug: https://pms.uniontech.com/bug-view-325731.html Change-Id: I377caf0def3455191a3189eac734a608443b47e6
Reviewer's GuideThis pull request replaces the unreliable hwinfo-based resolution detection with a new xrandr-output parser, integrates raw xrandr data throughout the monitor setup pipeline, and adds a UI auto-refresh to ensure supported resolutions are displayed correctly. Sequence diagram for xrandr-based monitor resolution detectionsequenceDiagram
participant ThreadExecXrandr
participant DeviceManager
participant DeviceMonitor
ThreadExecXrandr->>ThreadExecXrandr: runCmd(xrandr)
ThreadExecXrandr->>DeviceManager: setMonitorInfoFromXrandr(mainInfo, edid, rate, xrandr)
DeviceManager->>DeviceMonitor: setInfoFromXradr(main, edid, rate, xrandr)
DeviceMonitor->>DeviceMonitor: getMonitorResolutionMap(xrandr, m_RawInterface)
DeviceMonitor->>DeviceMonitor: Update m_SupportResolution
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review代码审查意见:
以上是针对代码提交的审查意见,希望能够帮助到开发者改进代码质量。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
496262e
into
linuxdeepin:develop/eagle
Fixed refresh rate errors and spelling mistakes in Device Manager → Display → Supported Resolutions. Now accurately obtains resolutions from xrandr output (keeping only integer values) instead of potentially problematic hwinfo detection.
Log: Fix display resolution detection method
Bug: https://pms.uniontech.com/bug-view-325731.html
Change-Id: I377caf0def3455191a3189eac734a608443b47e6
Summary by Sourcery
Replace the old hwinfo-based resolution detection with a new xrandr parsing approach to accurately gather supported resolutions and refresh rates, add a helper function for mapping resolutions, update the data flow to include raw xrandr output, and implement a UI refresh workaround for the Monitor page.
New Features:
Bug Fixes:
Enhancements:
Chores: