Skip to content

Conversation

@GongHeng2017
Copy link
Contributor

@GongHeng2017 GongHeng2017 commented Jul 24, 2025

-- Clear the preview cache to avoid duplicate infomation accumulation.

Log: add feature for GPU.
Task: https://pms.uniontech.com/task-view-378987.html

Summary by Sourcery

Enhancements:

  • Clear m_extraInfo in DeviceGpu::setGpuInfoByCustom to avoid information accumulation

-- Clear the preview cache to avoid duplicate infomation accumulation.

Log: add feature for GPU.
Task: https://pms.uniontech.com/task-view-378987.html
@sourcery-ai
Copy link

sourcery-ai bot commented Jul 24, 2025

Reviewer's Guide

This PR adds logic to clear the GPU info cache before populating new GPU details, preventing duplicate information accumulation when displaying GPU data.

Class diagram for updated DeviceGpu GPU info logic

classDiagram
    class DeviceGpu {
        +void setGpuInfo(const QMap<QString, QString> &mapInfo)
        +void setGpuInfoByCustom(const QMap<QString, QString> &mapInfo)
        -QMap<QString, QString> m_extraInfo
    }
    DeviceGpu : setGpuInfoByCustom() now calls m_extraInfo.clear() before populating new info
Loading

File-Level Changes

Change Details Files
Reset GPU info storage before processing new data
  • Add m_extraInfo.clear() at the start of setGpuInfoByCustom to clear previous entries
deepin-devicemanager/src/DeviceManager/DeviceGpu.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • setGpuInfoByCustom函数中新增了m_extraInfo.clear();,需要确认m_extraInfo是否应该被清空,以及是否有其他地方依赖m_extraInfo的原始数据。

是否建议立即修改:

  • 是,需要确保m_extraInfo的清空操作不会影响其他部分的逻辑,并且这个改动是有意为之。如果这个操作是无意的,可能会导致数据丢失或逻辑错误。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017
Copy link
Contributor Author

/forcemerge

@deepin-bot deepin-bot bot merged commit d705a5e into linuxdeepin:develop/eagle Jul 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants