Perf: Improve program performance

deepin-devicemanager/src/DriverControl/DBusDriverInterface.cpp

@@ -113,12 +113,12 @@ DBusDriverInterface::~DBusDriverInterface()
 
 }
 
-void DBusDriverInterface::slotProcessChange(qint32 value, QString detail)
+void DBusDriverInterface::slotProcessChange(qint32 value, const QString &detail)
 {
     emit processChange(value, detail);
 }
 
-void DBusDriverInterface::slotProcessEnd(bool success, QString msg)
+void DBusDriverInterface::slotProcessEnd(bool success, const QString &msg)
 {
     if (success) {
         emit processChange(100, "");
@@ -133,7 +133,7 @@ void DBusDriverInterface::slotCallFinished(QDBusPendingCallWatcher *watcher)
     watcher->deleteLater();
 }
 
-void DBusDriverInterface::slotDownloadProgressChanged(QStringList msg)
+void DBusDriverInterface::slotDownloadProgressChanged(const QStringList &msg)
 {
     emit downloadProgressChanged(msg);
 }

deepin-devicemanager/src/DriverControl/DBusDriverInterface.h

@@ -123,13 +123,13 @@ private slots:
      * @param value 当前处理的进度
      * @param detail 发送过来的时时信息
      */
-    void slotProcessChange(qint32 value, QString detail);
+    void slotProcessChange(qint32 value, const QString &detail);
 
     /**
      * @brief slotProcessEnd 接收后台结束信号
      * @param success
      */
-    void slotProcessEnd(bool success, QString msg);
+    void slotProcessEnd(bool success, const QString &msg);
 
     /**
      * @brief slotCallFinished 更新结束结束的回调
@@ -139,7 +139,7 @@ private slots:
     /**
      * @brief slotDownloadProgressChanged 驱动下载时回调，返回驱动下载进度、速度、已下载大小信息
      */
-    void slotDownloadProgressChanged(QStringList msg);
+    void slotDownloadProgressChanged(const QStringList &msg);
 
     /**
      * @brief slotDownloadFinished 驱动下载完成

deepin-devicemanager/src/DriverControl/DriverScanner.cpp

@@ -81,7 +81,7 @@
 //    emit scanFinished(SR_SUCESS);
 }
 
-void DriverScanner::setDriverList(QList<DriverInfo *> lstInfo)
+void DriverScanner::setDriverList(const QList<DriverInfo *> &lstInfo)
 {
     m_ListDriverInfo = lstInfo;
     m_IsStop = false;

deepin-devicemanager/src/DriverControl/DriverScanner.h

@@ -25,7 +25,7 @@ class DriverScanner : public QThread
      * @brief setDriverList
      * @param lstInfo
      */
-    void setDriverList(QList<DriverInfo *> lstInfo);
+    void setDriverList(const QList<DriverInfo *> &lstInfo);
 
 signals:
     void scanInfo(const QString &info, int progress);

deepin-devicemanager/src/GenerateDevice/CmdTool.cpp

@@ -184,7 +184,7 @@
     return QString();
 }
 
-bool CmdTool::parseOemTomlInfo(const QString filename)
+bool CmdTool::parseOemTomlInfo(const QString &filename)
 {
     bool tomlFileRead = false;
     bool tomlPars = false;
@@ -969,9 +969,9 @@
                 QRegExp reg("[\\s\\S]*VideoRam[\\s\\S]*([0-9]{4,})[\\s\\S]*");
                 QStringList list = deviceInfo.split("\n");
 
-                foreach (QString item, list) {
+                foreach (QString tmpInfo, list) {
                     // Attribute 'VideoRam' (jixiaomei-PC:0.0): 2097152.  正则表达式获取2097152
-                    if (reg.exactMatch(item)) {
+                    if (reg.exactMatch(tmpInfo)) {
                         QString gpuSize = reg.cap(1);
                         int numSize = gpuSize.toInt();
                         numSize /= 1024;

deepin-devicemanager/src/GenerateDevice/CmdTool.h

@@ -61,7 +61,7 @@ class CmdTool
         /**
      * @brief parseOemTomlInfo: 解析并加载厂商适配信息
      */
-    bool parseOemTomlInfo(const QString filename);
+    bool parseOemTomlInfo(const QString &filename);
 
 private:
 

deepin-devicemanager/src/GenerateDevice/CustomGenerator.h

@@ -11,7 +11,7 @@
 class CustomGenerator : public DeviceGenerator
 {
 public:
-    CustomGenerator(QObject *parent = nullptr);
+    explicit CustomGenerator(QObject *parent = nullptr);
 
     /**
      * @brief generatorGpuDevice:生成显卡信息

deepin-devicemanager/src/GenerateDevice/GenerateDevicePool.h

@@ -45,7 +45,7 @@ class GenerateTask: public QObject, public QRunnable
     Q_OBJECT
 
 public:
-    GenerateTask(DeviceType deviceType);
+    explicit GenerateTask(DeviceType deviceType);
     ~GenerateTask();
 signals:
     void finished(const QStringList &lst);

deepin-devicemanager/src/GenerateDevice/GetInfoPool.cpp

@@ -12,7 +12,7 @@
 
 static QMutex mutex;
 
-CmdTask::CmdTask(QString key, QString file, QString info, GetInfoPool *parent)
+CmdTask::CmdTask(const QString &key, const QString &file, const QString &info, GetInfoPool *parent)
     : m_Key(key)
     , m_File(file)
     , m_Info(info)

deepin-devicemanager/src/GenerateDevice/GetInfoPool.h

@@ -19,8 +19,8 @@ class CmdTask: public QObject, public QRunnable
 {
     Q_OBJECT
 public:
-    CmdTask(QString key, QString file, QString info, GetInfoPool *parent);
-    ~CmdTask();
+    CmdTask(const QString &key, const QString &file, const QString &info, GetInfoPool *parent);
+    ~CmdTask() override;
 protected:
     void run() override;
 

deepin-devicemanager/src/GenerateDevice/LoadInfoThread.h

@@ -16,7 +16,7 @@ class LoadInfoThread : public QThread
     Q_OBJECT
 public:
     LoadInfoThread();
-    ~LoadInfoThread();
+    ~LoadInfoThread() override;
 
     /**
      * @brief setFramework：设置架构

deepin-devicemanager/src/Page/DeviceWidget.h

@@ -26,7 +26,7 @@ class DeviceWidget : public DWidget
     Q_OBJECT
 public:
     explicit DeviceWidget(QWidget *parent = nullptr);
-    ~DeviceWidget();
+    ~DeviceWidget() override;
 
     /**
      * @brief updateListView:更新ListView

deepin-devicemanager/src/Page/MainWindow.cpp

@@ -474,7 +474,7 @@ void MainWindow::refreshDataBase()
     }
 }
 
-void MainWindow::slotSetPage(QString page)
+void MainWindow::slotSetPage(const QString &page)
 {
     if ("driver" == page) {
         if (m_IsFirstRefresh) {

deepin-devicemanager/src/Page/MainWindow.h

@@ -134,7 +134,7 @@ private slots:
      * @brief slotSetPage
      * @param page
      */
-    void slotSetPage(QString page);
+    void slotSetPage(const QString &page);
 
     /**
      * @brief loadingFinishSlot:加载设备信息结束 槽