fix: update translations #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JWWTSL The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThis PR introduces full Lao ( File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @JWWTSL - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `deepin-devicemanager/translations/desktop/desktop_lo.ts:5` </location>
<code_context>
+<context>
+ <name>desktop</name>
+ <message>
+ <location filename="Desktop Entry]Comment" line="0"/>
+ <source>Device Manager is a handy tool for viewing hardware information and managing the devices.</source>
+ <translation>ຕົວຈັດການອຸປະກອນແມ່ນເຄື່ອງມືທີ່ສະດວກສຳລັບເບິ່ງຂໍ້ມູນຮາດແວແລະຈັດການອຸປະກອນ.</translation>
</code_context>
<issue_to_address>
The 'filename' attribute in <location> contains an unexpected ']' character.
Please check and correct the 'filename' attribute to remove the extraneous ']' character, ensuring it matches the expected format for compatibility with translation tools.
</issue_to_address>
### Comment 2
<location> `deepin-devicemanager/translations/deepin-devicemanager_lo.ts:9` </location>
<code_context>
+ <message>
+ <location filename="../src/Widget/BtnLabel.cpp" line="44"/>
+ <source>OK</source>
+ <translation>ກម្រាស់</translation>
+ </message>
+ <message>
+ <location filename="../src/Widget/BtnLabel.cpp" line="45"/>
+ <source>Feedback</source>
+ <translation>ຄຳຄິດເຫັນ</translation>
+ </message>
+ <message>
+ <location filename="../src/Widget/BtnLabel.cpp" line="57"/>
+ <source>OK</source>
+ <comment>button</comment>
+ <translation>កម្រាស់</translation>
+ </message>
+</context>
</code_context>
<issue_to_address>
Inconsistent translation for the same source string.
Please standardize the translation of 'OK' to ensure consistency across the application.
</issue_to_address>
### Comment 3
<location> `deepin-devicemanager/translations/deepin-devicemanager_lo.ts:2723` </location>
<code_context>
+ <message>
+ <location filename="../src/DeviceManager/DeviceCpu.cpp" line="354"/>
+ <source>Sixty-two</source>
+ <translation>ຫ້າຫວາດ ཁວາງ དີ້</translation>
+ </message>
+ <message>
</code_context>
<issue_to_address>
Translation for 'Sixty-two' contains non-Lao script.
Please confirm if the use of non-Lao script in this translation is intentional or update it to use only Lao script.
</issue_to_address>
### Comment 4
<location> `deepin-devicemanager/translations/deepin-devicemanager_lo.ts:3073` </location>
<code_context>
+ <message>
+ <location filename="../src/DeviceManager/DeviceManager.cpp" line="1373"/>
+ <source>Power</source>
+ <translation>พลังงาน</translation>
+ </message>
+ <message>
</code_context>
<issue_to_address>
Translation for 'Power' is in Thai.
Please replace the Thai translation with the correct Lao translation for 'Power'.
</issue_to_address>
### Comment 5
<location> `deepin-devicemanager/translations/deepin-devicemanager_lo.ts:3113` </location>
<code_context>
+ <message>
+ <location filename="../src/DeviceManager/DeviceManager.cpp" line="1377"/>
+ <source>Camera</source>
+ <translation>กล้อง</translation>
+ </message>
+ <message>
+ <location filename="../src/DeviceManager/DeviceManager.cpp" line="1377"/>
+ <source>No camera found</source>
+ <translation>ไม่พบกล้อง</translation>
+ </message>
+ <message>
</code_context>
<issue_to_address>
Translations for 'Camera' and 'No camera found' are in Thai.
Please replace the Thai translations with the correct Lao translations for these strings.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <context> | ||
| <name>desktop</name> | ||
| <message> | ||
| <location filename="Desktop Entry]Comment" line="0"/> |
There was a problem hiding this comment.
issue: The 'filename' attribute in contains an unexpected ']' character.
Please check and correct the 'filename' attribute to remove the extraneous ']' character, ensuring it matches the expected format for compatibility with translation tools.
Comment on lines
+9
to
+18
| <translation>ກម្រាស់</translation> | ||
| </message> | ||
| <message> | ||
| <location filename="../src/Widget/BtnLabel.cpp" line="45"/> | ||
| <source>Feedback</source> | ||
| <translation>ຄຳຄິດເຫັນ</translation> | ||
| </message> | ||
| <message> | ||
| <location filename="../src/Widget/BtnLabel.cpp" line="57"/> | ||
| <source>OK</source> |
There was a problem hiding this comment.
issue: Inconsistent translation for the same source string.
Please standardize the translation of 'OK' to ensure consistency across the application.
| <message> | ||
| <location filename="../src/DeviceManager/DeviceCpu.cpp" line="354"/> | ||
| <source>Sixty-two</source> | ||
| <translation>ຫ້າຫວາດ ཁວາງ དີ້</translation> |
There was a problem hiding this comment.
issue: Translation for 'Sixty-two' contains non-Lao script.
Please confirm if the use of non-Lao script in this translation is intentional or update it to use only Lao script.
| <message> | ||
| <location filename="../src/DeviceManager/DeviceManager.cpp" line="1373"/> | ||
| <source>Power</source> | ||
| <translation>พลังงาน</translation> |
There was a problem hiding this comment.
issue: Translation for 'Power' is in Thai.
Please replace the Thai translation with the correct Lao translation for 'Power'.
Comment on lines
+3113
to
+3118
| <translation>กล้อง</translation> | ||
| </message> | ||
| <message> | ||
| <location filename="../src/DeviceManager/DeviceManager.cpp" line="1377"/> | ||
| <source>No camera found</source> | ||
| <translation>ไม่พบกล้อง</translation> |
There was a problem hiding this comment.
issue: Translations for 'Camera' and 'No camera found' are in Thai.
Please replace the Thai translations with the correct Lao translations for these strings.
lzwind
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log:
Summary by Sourcery
Add Lao language translations for the Device Manager UI, desktop entry, and authentication policy prompts
New Features: