Skip to content

Conversation

@GongHeng2017
Copy link
Contributor

@GongHeng2017 GongHeng2017 commented Sep 19, 2025

-- Get battery percentage from DDE.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-333825.html

Summary by Sourcery

Fetch battery percentage from DDE system Power DBus interface instead of UPower data to correct the displayed value

Bug Fixes:

  • Fix battery percentage display error by retrieving the value through com.deepin.system.Power DBus interface

Enhancements:

  • Add DBus interface constants and use QDBusInterface to obtain and format the battery percentage

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 19, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Battery percentage retrieval is updated to use the DDE power service via D-Bus for consistency with the status bar, and Qt include directives are standardized.

File-Level Changes

Change Details Files
Standardize include directives and add QDBusInterface header
  • Replaced '#include' with '#include '
  • Added '#include '
deepin-devicemanager/src/DeviceManager/DevicePower.cpp
Fetch battery percentage via DDE power service D-Bus interface
  • Added kPowerService, kPowerPath and kPowerInterface constants
  • Instantiated QDBusInterface to com.deepin.system.Power on the system bus
  • Overrode tmpMapInfo['percentage'] with BatteryPercentage property
  • Logged critical error if D-Bus interface is invalid
  • Replaced getOtherMapInfo(mapInfo) call with getOtherMapInfo(tmpMapInfo)
deepin-devicemanager/src/DeviceManager/DevicePower.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 19, 2025

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 3bf91af into linuxdeepin:develop/eagle Sep 19, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants