-
Notifications
You must be signed in to change notification settings - Fork 38
fix: Correct serialization of command count in SDynamicLayerUnitData #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the serialization method to cast the command count to an integer before outputting, ensuring proper data type handling. Log: fix bug Bug: https://pms.uniontech.com/bug-view-327629.html
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnsure proper serialization of the command count by casting to int before output, addressing data type consistency. Class diagram for SDynamicLayerUnitData serialization updateclassDiagram
class SDynamicLayerUnitData {
+baseImg
+blocked
+layerType
+commands
+serialization(out)
}
class Command {
+cmdType()
+serialization(out)
}
SDynamicLayerUnitData "1" o-- "*" Command : commands
SDynamicLayerUnitData : serialization(out)
%% Highlight change: command count is now cast to int during serialization
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as title Log: update version
|
TAG Bot TAG: 6.5.31 |
deepin pr auto review根据提供的git diff,我将对代码进行审查,并提出改进意见:
out << layUnit.commands.count();被修改为: out << static_cast<int>(layUnit.commands.count());改进意见:
总体评价:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kakueeen, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
Updated the serialization method to cast the command count to an integer before outputting, ensuring proper data type handling.
Log: fix bug
Bug: https://pms.uniontech.com/bug-view-327629.html
Summary by Sourcery
Bug Fixes: