Skip to content

Conversation

@add-uos
Copy link
Contributor

@add-uos add-uos commented Oct 16, 2025

  • Removed MIT license file from LICENSES directory
  • Eliminated pkg-config dependency from Debian build requirements
  • Maintained core build dependencies including cmake, debhelper, and Qt6 toolchain

Log: Update license and build dependencies

@add-uos add-uos changed the title feat: Adjust open source license configuration chore: Adjust open source license configuration Oct 16, 2025
- Removed MIT license file from LICENSES directory
- Eliminated pkg-config dependency from Debian build requirements
- Maintained core build dependencies including cmake, debhelper, and Qt6 toolchain

Log: Update license and build dependencies
@deepin-ci-robot
Copy link

deepin pr auto review

根据提供的git diff,我看到两个主要的变更:

  1. 删除了MIT.txt许可证文件
  2. 修改了debian/control文件,移除了pkg-config依赖

针对这些变更,我有以下审查意见:

  1. 关于删除MIT.txt许可证文件:

    • 这是一个重要的法律文件,删除它可能会带来法律风险
    • 建议:
      a) 确认项目中是否真的不再需要MIT许可证
      b) 如果项目确实不再使用MIT许可证,确保有适当的替代许可证文件
      c) 考虑在删除前确认所有相关文件都符合新的许可证要求
      d) 如果这是一个误操作,应该立即恢复该文件
  2. 关于debian/control中移除pkg-config依赖:

    • 这是一个系统包管理相关的变更
    • 建议:
      a) 确认移除pkg-config后,构建过程是否仍然能够正常工作
      b) 检查项目中是否有任何组件或库依赖于pkg-config来定位系统包
      c) 如果确实需要pkg-config,应该将其重新添加到Build-Depends中
      d) 如果确定不需要,应该在代码中确认所有相关的pkg-config调用已被移除

总体建议:

  1. 在进行这样的重大变更前,应该进行充分的测试
  2. 建议记录下为什么做出这些变更,以便将来参考
  3. 确保团队的所有成员都了解这些变更及其潜在影响
  4. 考虑在变更实施前进行代码审查,特别是涉及法律文件和构建系统时

这些变更看起来可能影响项目的构建和法律合规性,建议谨慎处理并确保所有相关方都了解这些变更的后果。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit 6a7454e into linuxdeepin:master Oct 16, 2025
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants