Skip to content

Conversation

@add-uos
Copy link
Contributor

@add-uos add-uos commented Oct 16, 2025

  • Removed PkgConfig requirement from CMake configuration

Log: Update build dependencies for license compliance

 - Removed PkgConfig requirement from CMake configuration

Log: Update build dependencies for license compliance
@deepin-ci-robot
Copy link

deepin pr auto review

我已仔细审查了这段CMakeLists.txt的代码变更,以下是分析意见:

语法逻辑

  • 语法正确,CMake命令使用规范
  • 删除了find_package(PkgConfig REQUIRED)这一行,但后续仍然使用了pkg_check_modules命令,这可能会导致问题

代码质量

  • 移除find_package(PkgConfig REQUIRED)但没有其他替代方案来提供pkg-config功能
  • 如果系统中没有安装PkgConfig,后续的pkg_check_modules命令将无法正常工作

代码性能

  • 此变更对构建性能没有明显影响

代码安全

  • 移除必要的依赖检查可能导致构建失败
  • 如果dtk6ocr、ncnn或opencv_mobile这些依赖未正确安装,项目将无法构建

改进建议

  1. 如果项目确实需要pkg-config功能,应该保留find_package(PkgConfig REQUIRED)这一行
  2. 如果项目不需要pkg-config,应该将pkg_check_modules替换为CMake原生的find机制:
    find_package(PkgConfig)
    if(PkgConfig_FOUND)
        pkg_check_modules(ocr_lib REQUIRED dtk6ocr)
        pkg_check_modules(InferenceEngine REQUIRED ncnn opencv_mobile)
    else()
        message(FATAL_ERROR "PkgConfig is required but not found")
    endif()
  3. 或者使用CMake的find_package直接查找这些库,而不是依赖pkg-config机制

总结:这个变更可能导致构建问题,建议恢复或替换为更可靠的依赖查找机制。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit 8873f95 into linuxdeepin:master Oct 16, 2025
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants