Skip to content

Conversation

@dengzhongyuan365-dev
Copy link
Contributor

Update the version of deepin-reader to 6.5.19 in all relevant files and add a new dependency for libqt6webenginecore6-bin. Update changelog accordingly.

Update the version of deepin-reader to 6.5.19 in all relevant files and add a new dependency for libqt6webenginecore6-bin. Update changelog accordingly.
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 版本号更新

    • arm64/linglong.yamldebian/changeloglinglong.yamlloong64/linglong.yaml文件中,版本号从6.5.18.1更新到6.5.19.1。确认是否有相应的代码更新和测试来支持这个版本号的变更。
  2. 依赖项更新

    • debian/control文件中,新增了libqt6webenginecore6-bin [!mipsel !mips64el] | libqt5core5a作为依赖项。确认这个依赖项是否确实需要,以及是否有相应的文档说明为什么需要这个特定的版本或条件。
  3. 格式化

    • debian/control文件中,依赖项列表的格式化有些不一致,建议统一格式以提高可读性。例如,可以删除多余的空格和换行符。
  4. 注释

    • debian/changelog文件中,更新日志的注释应该更详细地描述版本更新的内容,而不仅仅是“Update version to 6.519”。这有助于其他开发者理解版本更新的原因和影响。
  5. 文件权限

    • loong64/linglong.yaml文件中,文件权限从100755更改为100644。确认这是否是预期的更改,因为100755通常用于可执行文件。
  6. 文件路径

    • 确认所有更改的文件路径是否正确,并且这些文件确实存在于项目中。
  7. 测试

    • 在进行版本更新和依赖项更改后,应该运行全面的测试以确保这些更改不会引入任何问题。
  8. 文档

    • 确保更新后的文档(如debian/changelog)与代码更改保持同步,以便其他开发者能够理解这些更改的上下文。

总体来说,这些更改看起来是合理的,但需要确保所有相关的更改都已经经过充分的测试和文档记录。

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

TAG Bot

TAG: 6.5.19
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit 42abe85 into linuxdeepin:master Apr 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants