Skip to content

Fix: Add file type check for highlight action to match remove highlig… #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Dec 18, 2025
Merged

Fix: Add file type check for highlight action to match remove highlig… #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions reader/browser/BrowserMenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,17 @@ void BrowserMenu::initActions(DocSheet *sheet, int index, SheetMenuType_e type,
}
this->addSeparator();

QAction *highAct = createAction(tr("Highlight"), type != DOC_MENU_SELECT_TEXT ? "ChangeAnnotationColor" : "AddTextHighlight");
if (type == DOC_MENU_ANNO_HIGHLIGHT) {
qCDebug(appLog) << "BrowserMenu::initActions() - Disabling highlight action for annotation highlight";
highAct->setDisabled(true);
}
if (sheet->fileType() == Dr::FileType::PDF || sheet->fileType() == Dr::FileType::DOCX) {
QAction *highAct = createAction(tr("Highlight"), type != DOC_MENU_SELECT_TEXT ? "ChangeAnnotationColor" : "AddTextHighlight");
if (type == DOC_MENU_ANNO_HIGHLIGHT) {
qCDebug(appLog) << "BrowserMenu::initActions() - Disabling highlight action for annotation highlight";
highAct->setDisabled(true);
}

m_pColorWidgetAction = new ColorWidgetAction(this);
connect(m_pColorWidgetAction, SIGNAL(sigBtnGroupClicked()), this, SLOT(onSetHighLight()));
this->addAction(m_pColorWidgetAction);
m_pColorWidgetAction = new ColorWidgetAction(this);
connect(m_pColorWidgetAction, SIGNAL(sigBtnGroupClicked()), this, SLOT(onSetHighLight()));
this->addAction(m_pColorWidgetAction);
}

if (sheet->fileType() == Dr::FileType::PDF || sheet->fileType() == Dr::FileType::DOCX) {
qCDebug(appLog) << "BrowserMenu::initActions() - Adding PDF/DOCX highlight actions";
Expand Down