Skip to content

Conversation

@GongHeng2017
Copy link
Contributor

-- The Next button should clicked double.
-- The last animation not stop and logic return.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-328371.html

-- The Next button should clicked double.
-- The last animation not stop and logic return.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-328371.html
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

libimageviewer/slideshow/imageanimation.cpp 文件中的改动:

  1. 新增 forceStopCurrentAnimation 函数:

    • 代码逻辑清晰,将停止动画的逻辑提取到一个独立的函数中,提高了代码的可读性和可维护性。
    • 确保所有相关的计时器都被正确停止,并且动画状态被重置。
  2. 修改 startSingleNextAnimationstartSinglePreAnimation 函数:

    • 通过调用 forceStopCurrentAnimation 函数来停止当前动画,避免了重复代码。
    • 直接设置 m_isAnimationIngfalse 可能会导致状态不一致的问题,建议在停止计时器后明确设置动画状态。

libimageviewer/unionimage/unionimage.cpp 文件中的改动:

  1. 修改了 #include 路径:
    • 将相对路径改为绝对路径,这有助于解决路径问题,但可能会影响项目的可移植性。

总体来说,代码改动提高了代码质量,但需要注意以下几点:

  • forceStopCurrentAnimation 函数中,将 m_continuousanimationTimer 的间隔设置为 0 可能会导致计时器无法再次启动,建议使用 reset 方法。
  • startSingleNextAnimationstartSinglePreAnimation 函数中,应该明确设置 m_isAnimationIngfalse,以确保动画状态的一致性。
  • 对于路径修改,需要考虑项目的可移植性,可能需要提供一种更灵活的路径配置方式。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017
Copy link
Contributor Author

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 13, 2025

This pr cannot be merged! (status: unstable)

@GongHeng2017
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 13, 2025

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 3ba0572 into linuxdeepin:develop/eagle Aug 13, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants