-
Notifications
You must be signed in to change notification settings - Fork 31
test: Add initFFmpegVideoThumbnailer unit test. #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deepin ChatOps Bot |
|
/check obs |
|
/check obs |
|
Deepin Obs Bot |
e3bc86d to
d1bc1ed
Compare
|
TAG Bot New tag: 1.0.40 |
|
TAG Bot New tag: 1.0.41 |
|
TAG Bot New tag: 1.0.42 |
|
TAG Bot New tag: 1.0.43 |
|
TAG Bot New tag: 1.0.44 |
|
TAG Bot New tag: 1.0.45 |
|
TAG Bot New tag: 1.0.46 |
|
TAG Bot New tag: 1.0.47 |
|
TAG Bot New tag: 6.5.0 |
完善 initFFmpegVideoThumbnailer() ,添加备用的查找库方式 和提示信息。在 QLibrary 无法查找时尝试使用手动查找方式取得 其它版本的 libffmpegthumbnailer.so 动态库。 Log: 补充适配缩略图查找方式和UT Bug: https://pms.uniontech.com/bug-view-213565.html Bug: https://pms.uniontech.com/bug-view-221557.html Influence: VideoThumbnailer Change-Id: Id33c13f1c5d9b4c6ecaada2ae50e714f2d40a3d6
deepin pr auto review代码审查意见:
综上所述,代码需要改进的地方包括:增加详细的注释、优化错误处理、减少代码重复、管理资源生命周期、改进测试描述、保持一致的代码风格、增强安全性以及考虑性能优化。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pengfeixx, rb-union The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
完善 initFFmpegVideoThumbnailer() ,添加备用的查找库方式
和提示信息。在 QLibrary 无法查找时尝试使用手动查找方式取得
其它版本的 libffmpegthumbnailer.so 动态库。
Log: 补充适配缩略图查找方式和UT
Bug: https://pms.uniontech.com/bug-view-213565.html
Bug: https://pms.uniontech.com/bug-view-221557.html
Influence: VideoThumbnailer