fix: prevent invalid member organization date ranges (DE-931)#4065
Open
fix: prevent invalid member organization date ranges (DE-931)#4065
Conversation
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 01b646b. Configure here.
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Note
Medium Risk
Touches multiple write paths (public API, core member-org service, enrichment worker) and changes date nullability/validation behavior, which could affect existing clients and deduplication/unique-conflict behavior if assumptions about date formats differ.
Overview
Prevents invalid member work-experience date ranges from being persisted by introducing a shared
sanitizeMemberOrganizationDateRangehelper and wiring it into create/update flows.Public work-experience
create/updateendpoints now validate/sanitizestartDate/endDateand return400 BadRequeston invalid ranges, and the member org service layer applies the same validation (including for partial updates) while recalculating affiliations for both the old and new org when the org changes.The enrichment worker now normalizes incoming work-experience dates (invalid ranges become
null), updates enrichment organization types to allownulldates, and related types/data-access code are adjusted to accept nullabledateStart/dateEndplus a newfetchMemberOrganizationByIdhelper for safer updates.Reviewed by Cursor Bugbot for commit ba435cc. Bugbot is set up for automated code reviews on this repo. Configure here.