Merge Fin AI best practices into lfx-intercom skill#46
Open
clkrueger wants to merge 5 commits intolinuxfoundation:mainfrom
Open
Merge Fin AI best practices into lfx-intercom skill#46clkrueger wants to merge 5 commits intolinuxfoundation:mainfrom
clkrueger wants to merge 5 commits intolinuxfoundation:mainfrom
Conversation
This document provides best practices for optimizing Fin AI Agent performance, including guidance on writing, content optimization, daily reviews, and AI suggestions. Signed-off-by: Connie Krueger <ckrueger9700@gmail.com>
Updated the LFX Intercom skill documentation to enhance clarity and detail regarding integration steps, context detection, and environment configuration. Signed-off-by: Connie Krueger <ckrueger9700@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates Intercom guidance into a single lfx-intercom skill by adding Fin AI optimization best practices and introducing a context-detection “Step 0” to route users to either developer integration guidance or support/CX optimization guidance.
Changes:
- Expanded
lfx-intercomskill frontmatter and added “Step 0 — Detect Context” routing guidance. - Added a new Fin AI best-practices reference document under
lfx-intercom/references/.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lfx-intercom/SKILL.md | Updates skill description and adds context routing, but currently removes the detailed Angular integration workflow content. |
| lfx-intercom/references/fin-best-practices.md | Adds a Support/CX-facing reference with Fin optimization pillars, improvement loops, tagging, escalation, and benchmarks. |
Comments suppressed due to low confidence (1)
lfx-intercom/SKILL.md:41
- The PR description says Fin best practices are being merged into the existing lfx-intercom skill, but this change also removes the entire previous Angular Intercom integration workflow (Steps 1–7) and leaves the “## Code Integration” section with only a two-line introduction. As-is, the skill no longer provides the canonical integration/audit steps it previously encoded and does not meet the acceptance criterion of handling developer integration questions. Please restore the original integration steps under “## Code Integration”, or move them into a separate reference file and link to it here.
## Code Integration
You are bringing Intercom up to the LFX standard in an Angular application. This
skill handles both fresh installs and fixing/standardizing existing integrations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…itions Updated the SKILL.md file to enhance the Intercom integration process, including detailed steps for setup, auditing, and verification. Signed-off-by: Connie Krueger <ckrueger9700@gmail.com>
Updated formatting in SKILL.md to correct typographic errors and ensure consistency in bullet points and headings. Signed-off-by: Connie Krueger <ckrueger9700@gmail.com>
mlehotskylf
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43
Summary
Merges Fin AI best practices content into the existing
lfx-intercomskill rather than maintaining a separate skill, as agreed with @niravpatel27 and @mlehotsky. This makeslfx-intercomthe single entry point for all Intercom questions at LFX, with context-based routing to the right section.What's changed
lfx-intercom/SKILL.mddescriptionfrontmatter to cover both audiences (Angular developers and support/CX teams)lfx-intercom/references/fin-best-practices.md(new)Acceptance criteria
lfx-intercomskill handles both developer and support/CX Intercom questionsreferences/fin-best-practices.mdSupersedes PR #44.