fix(pr-resolve): push changes before commenting on PR threads#47
Merged
fix(pr-resolve): push changes before commenting on PR threads#47
Conversation
Reorder steps so the git push happens before any GitHub API interactions (thread replies, thread resolution, summary comment). This prevents bots and reviewers from being notified and attempting to validate changes before the code is available on the remote. Also fixes a stale step reference for discussion items (Step 3 → Step 4). Signed-off-by: Asitha de Silva <asithade@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the lfx-pr-resolve workflow documentation to ensure local changes are pushed to the remote branch before any GitHub API interactions (thread replies/resolutions and summary comment), preventing notifications before reviewers can see the updated code.
Changes:
- Reordered steps so
git pushhappens before replying to/reconciling PR review threads and posting the summary. - Renumbered subsequent steps to match the new ordering.
- Fixed an incorrect step reference for handling discussion items (Step 3 → Step 4).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jordane
approved these changes
Apr 14, 2026
MRashad26
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git push(now Step 8) happens before any GitHub API interactions — thread replies (Step 9), thread resolution (Step 10), and summary comment (Step 11)🤖 Generated with Claude Code