feat(lfx-data-engineer): add new skill for generating dbt models and …#48
Open
feat(lfx-data-engineer): add new skill for generating dbt models and …#48
Conversation
…SQL transformations Introduces the `/lfx-data-engineer` skill to guide users in creating PR-ready dbt models, tests, and SQL transformations. This skill encodes the medallion architecture, Snowflake SQL conventions, and includes comprehensive references for setup, debugging, and style guidelines. New references added: - `getting-started.md`: Initial setup and prerequisites for using lf-dbt. - `medallion-architecture.md`: Overview of the medallion architecture layers. - `sql-style-guide.md`: Consolidated SQL formatting rules. - `debugging-pipelines.md`: Common failure patterns and resolutions. - `key-macros.md`: Reference for frequently used macros in the project. The README has been updated to include the new skill and its capabilities. Signed-off-by: Shane Kalepp <shane.kalepp@yahoo.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new /lfx-data-engineer skill to the LFX skills system, including end-user documentation and reference guides aimed at producing PR-ready dbt models and SQL transformations aligned to lf-dbt conventions.
Changes:
- Integrated
/lfx-data-engineerinto the main README (skill list, architecture diagram, skill table, workflows, and repo structure). - Added the
/lfx-data-engineerskill definition with workflows, validation expectations, and conventions. - Added dbt reference docs (getting started, debugging, style guide, testing patterns, medallion architecture, key macros).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the new skill across the skill system overview, workflows, and directory structure. |
| lfx-data-engineer/SKILL.md | Defines the skill’s behavior, conventions, validation steps, and examples for dbt development. |
| lfx-data-engineer/references/getting-started.md | Onboarding guide for lf-dbt environment setup and common commands. |
| lfx-data-engineer/references/debugging-pipelines.md | Troubleshooting guide for dbt/sqlfluff failures and debugging workflow. |
| lfx-data-engineer/references/sql-style-guide.md | SQL formatting and linting conventions aligned to sqlfluff + project standards. |
| lfx-data-engineer/references/testing-patterns.md | dbt YAML testing conventions (patterns, config nesting, PII tagging). |
| lfx-data-engineer/references/medallion-architecture.md | Explains layer responsibilities, conventions, examples, and schema mapping. |
| lfx-data-engineer/references/key-macros.md | Reference documentation for commonly used lf-dbt macros and their intended usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
niravpatel27
previously approved these changes
Apr 13, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Shane Kalepp <40646811+skalepp@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Shane Kalepp <40646811+skalepp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive documentation and support for the new
/lfx-data-engineerskill, which generates PR-ready dbt models and SQL transformations. It updates the mainREADME.mdto describe this new skill, details its capabilities, and integrates it into the skill system overview and directory structure. Additionally, it introduces a set of reference guides for dbt development, including setup, debugging, style, and workflow documentation.Skill system and documentation updates:
/lfx-data-engineerto the skill list, skill system diagram, and skill table inREADME.md, describing its purpose as a dbt model and SQL transformation generator. [1] [2] [3]/lfx-data-engineerin detail, outlining medallion architecture layers, key capabilities, and included reference docs./lfx-data-engineerand its references. [1] [2]Reference documentation for dbt development:
lfx-data-engineer/references/getting-started.mdwith environment setup, dbt commands, Makefile targets, and project structure guidance.lfx-data-engineer/references/debugging-pipelines.mdcovering common dbt and sqlfluff errors, troubleshooting, and debugging workflow.These changes ensure that both the skill system and its documentation are up to date, and provide clear onboarding and troubleshooting resources for data engineering tasks in the project.