Conversation
Contributor
|
I am a bot, here are the test results for this PR:
|
thespad
approved these changes
Mar 5, 2026
github-project-automation
bot
moved this from PRs Ready For Team Review
to PRs Approved
in Issue & PR Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the CI test results are added to PRs as comments only if the build succeeds. However, it is very useful to know when the build fails as a result of the CI test failing, as it suggests a runtime issue.
Another issue is, if a PR has a commit with a successful CI test, followed by a commit with a failing CI test, the comments in the PR will be misleading as the last comment will show a successful build.
This PR ensures that the PR comment is added every time the CI test is completed, whether successful or not.