Conversation
| client_id.c_str()); | ||
| goto destroy_context; | ||
| } | ||
| mo.authtype = "AzAuthAAD"; |
There was a problem hiding this comment.
lets set this value in constructor.
|
|
||
| failed_get_clientip: | ||
| // Build and cache the client ID only once | ||
| static std::string client_id = std::to_string(get_current_usecs()) + "-" + std::string(ip); |
There was a problem hiding this comment.
Random number from /opt/microsoft/aznfs/data/client -- file and concatenate with macaddress.
There was a problem hiding this comment.
Lets create 16bytes random number which is same for all connection and valid till this process is up.
|
|
||
| return client_id; | ||
|
|
||
| failed_get_clientip: |
There was a problem hiding this comment.
Failed case return empty client_id which means error and mount should fail without client-id.
| } | ||
|
|
||
| cb_res->azauth_data = strdup("None"); | ||
| cb_res->expiry_time = static_cast<uint64_t>(time(NULL))+300; |
There was a problem hiding this comment.
If you handle in AzAuthNone in rpc_auth_needs_refresh() then you don't need this .
|
|
||
| failed_get_clientip: | ||
| // Build and cache the client ID only once | ||
| static std::string client_id = std::to_string(get_current_usecs()) + "-" + std::string(ip); |
There was a problem hiding this comment.
Lets create 16bytes random number which is same for all connection and valid till this process is up.
| } | ||
|
|
||
| cb_res->azauth_data = strdup("None"); | ||
| cb_res->expiry_time = static_cast<uint64_t>(time(NULL))+300; |
There was a problem hiding this comment.
If you handle in AzAuthNone in rpc_auth_needs_refresh() then you don't need this .
| return cb_res; | ||
| } | ||
|
|
||
| uint64_t set_azauth_res_sc_cb(uint64_t server_cap_map) |
There was a problem hiding this comment.
Please remove this capability code.
| } else { | ||
| set_auth_token_callback(get_auth_token_and_setargs_cb_none); | ||
| } | ||
| set_azauth_res_callback(set_azauth_res_sc_cb); |
There was a problem hiding this comment.
Remove this one also
No description provided.