-
Notifications
You must be signed in to change notification settings - Fork 19
feat(cli-vector): implement reports and docs commands BM-1215 #3451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tawera-manaena
wants to merge
15
commits into
master
Choose a base branch
from
feat/etl-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f01f63 to
ab46f46
Compare
|
We've changed direction regarding how we will automatically generating schema-like documentation. I will look to close this pull request once I've built our desired solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that we can generate Shortbread MBTiles, we need a system for automatically generating schema-like documentation. The system should create markdown files detailing the layers, features within those layers, and attributes for each feature, similar to Shortbread's Vector Tile Schema documentation.
Modifications
This work introduces two new cli commands for the
cli-vectorpackage:reports
Parses an MBTiles file to extract and report detailed information about its contents. Identifies the layers, features within those layers, and attributes for each feature. For each identified layer, the command exports a JSON Report file, saving it into the target directory.
Inputs
UrlUrlFolderOutputs
For each layer extracted from the MBTiles file:
${layer.name}.jsonReportdocs
Parses a directory of JSON Report files, a directory of JSON Schema files, and a Mustache template file to generate a collection of Vector Tile schema-like markdown files. For each JSON Report file, the command re-maps the report into a runtime Doc object, feeds the Doc into Mustache, and then exports a Markdown file, saving it into the target directory.
Inputs
UrlFolderUrlFolderUrlUrlOutputs
For each JSON Report file:
${layer.name}.mdVerification