Skip to content

Factor out registry#236

Merged
zanerock merged 12 commits intoliquid-labs:mainfrom
zanerock:work-liquid-labs/plugable-express/235
Sep 21, 2025
Merged

Factor out registry#236
zanerock merged 12 commits intoliquid-labs:mainfrom
zanerock:work-liquid-labs/plugable-express/235

Conversation

@zanerock
Copy link
Member

@zanerock zanerock commented Sep 21, 2025

Pull request to resolve #235

Submitted by: zanerock

Instructions

Review all code changes. Verify the submitter attestations belowe, checking off each statement to indicate that you have reviewed the statement and it is true to the best of your knowledge. If you do not agree with or are unsure of a statement, then add a comment describing your questions or concerns and contact the submitter @zanerock for clarification.

QA files

Submitter attestations

To be verified by reviewer.

  • Do the changes implement all concrete TODOs in the change ticket? y (WORK_SUBMIT_IMPLEMENT_ALL_TODOS=true)
  • Are there other changes not described in the original work description? n (WORK_SUBMIT_HAS_ADDITIONAL_CHANGES=false)
  • Do the changes add or involve connections, authentication, or queries to a database or any third-party service? n (WORK_SUBMIT_THIRD_PARTY_SERVICES_MODIFIED=false)
  • Has all debug, hard coded test data, and hard coded authentication data been removed? y (WORK_SUBMIT_DEBUG_REMOVED=true)
  • I have reviewed and verified the above are true to the best of my knowledge.

@zanerock zanerock added this to the 1.0.0-beta milestone Sep 21, 2025
@zanerock zanerock self-assigned this Sep 21, 2025
@zanerock zanerock merged commit 8ace772 into liquid-labs:main Sep 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Factor out registry

1 participant