Save memory in PointingProvider.get_pointings #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointingProvider.get_pointings used to run the slerp operation over the whole timeline, thus allocating a significant amount of memory. Now the class' constructor accepts a new argument that limits the maximum amount of memory for the temporary buffer used to store the fully-sampled quaternions (default is 256 MB). This should slow a bit the generation of pointings, but it has the advantage to limit the amount of memory needed for a simulation run.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PointingProvider.get_pointings used to run the slerp operation over the whole timeline, thus allocating a significant amount of memory. Now the class' constructor accepts a new argument that limits the maximum amount of memory for the temporary buffer used to store the fully-sampled quaternions (default is 256 MB). This should slow a bit the generation of pointings, but it has the advantage to limit the amount of memory needed for a simulation run.