Cache crawler - run within a certain range of time only #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-hai
reviewed
Mar 4, 2024
hi-hai
reviewed
Mar 4, 2024
tynanbe
suggested changes
Mar 6, 2024
|
@lslisa will need to review wording and document new functionality. |
lslisa
reviewed
Mar 11, 2024
lslisa
reviewed
Mar 11, 2024
hi-hai
reviewed
Apr 16, 2024
src/crawler.cls.php
Outdated
| * | ||
| * @since 6.1 | ||
| */ | ||
| public static function _crawler_in_schedule_time() |
There was a problem hiding this comment.
function that calls this function is static
hi-hai
reviewed
Apr 16, 2024
tpl/crawler/settings-general.tpl.php
Outdated
| <div class="litespeed-desc"> | ||
| <?php echo __('Specify the crawler running periods.', 'litespeed-cache'); ?> | ||
| <br /> | ||
| <?php echo sprintf( __('You can add multiple ranges in 24-hour format <code>HH:mm-HH:mm</code> delimited by %s', 'litespeed-cache'), '<code>,</code>'); ?> |
There was a problem hiding this comment.
Time format shouldn't be in translatable string.
hi-hai
reviewed
Apr 16, 2024
tpl/crawler/settings-general.tpl.php
Outdated
| <br /> | ||
| <?php echo sprintf( __('You can add multiple ranges in 24-hour format <code>HH:mm-HH:mm</code> delimited by %s', 'litespeed-cache'), '<code>,</code>'); ?> | ||
| <br /> | ||
| <?php echo sprintf( __('Server time: %s', 'litespeed-cache'), '<code>'. date('H:m') . '</code>'); ?> |
There was a problem hiding this comment.
It is redundant to use sprintf here
There was a problem hiding this comment.
removed and left only __
hi-hai
reviewed
Apr 17, 2024
tpl/crawler/settings-general.tpl.php
Outdated
| <?php echo __('Specify the crawler running periods.', 'litespeed-cache'); ?> | ||
| <br /> | ||
| <?php echo sprintf( __('You can add multiple ranges in 24-hour format <code>HH:mm-HH:mm</code> delimited by %s', 'litespeed-cache'), '<code>,</code>'); ?> | ||
| <?php echo sprintf( __('You can add multiple ranges in 24-hour format <code>%s</code> delimited by %s', 'litespeed-cache'), 'HH:mm-HH:mm', '<code>,</code>'); ?> |
hi-hai
reviewed
Apr 17, 2024
tpl/crawler/settings-general.tpl.php
Outdated
| <?php echo sprintf( __('You can add multiple ranges in 24-hour format <code>%s</code> delimited by %s', 'litespeed-cache'), 'HH:mm-HH:mm', '<code>,</code>'); ?> | ||
| <br /> | ||
| <?php echo sprintf( __('Server time: %s', 'litespeed-cache'), '<code>'. date('H:m') . '</code>'); ?> | ||
| <?php echo __('Server time:', 'litespeed-cache') . ' <code>'. date('H:m') . '</code>'; ?> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.