Skip to content
This repository was archived by the owner on Aug 8, 2025. It is now read-only.

Conversation

@davidslater
Copy link

Fixes #194

Details on approach in linked issue.

@davidslater
Copy link
Author

Removed _MaybeSequence and reference to typing.Sequence, as they are no longer used.

@talglobus
Copy link

Any updates on this? Seems to solve a pretty significant occasional bug

@davidslater
Copy link
Author

No response as of yet.

@ryuthao
Copy link

ryuthao commented Aug 14, 2023

Just ran into this today, and was suspecting that _MaybeSequence wasn't accepting list. Luckily, there was your original issue and this PR that led me to try Tuples instead.

To support this PR, it's stated in the README.md that a tuple is explicitly accepted.

Add ellipsis for 2 more exceptions.
@davidslater
Copy link
Author

@frost-nzcr4 I think I did what you asked there.

@davidslater
Copy link
Author

davidslater commented Dec 2, 2024

@frost-nzcr4 can you merge this now? (I don't have write access, so I cannot merge.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Typing and Error Handling in on_exception

4 participants