Skip to content

refactor(use-interval): make it use loop internally, change delay t… #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wad4444 wants to merge 2 commits into from
Closed

refactor(use-interval): make it use loop internally, change delay t… #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3ae8d0
refactor(use-interval): make it use loop internally, change `delay` t…
wad4444 Jun 1, 2025
e762051
fix: eslint warnings
wad4444 Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/use-interval/use-interval.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useCallback, useEffect, useRef } from "@rbxts/react";
import { setInterval } from "@rbxts/set-timeout";
import { useLatestCallback } from "../use-latest-callback";
import { BindingOrValue, getBindingValue } from "../utils/binding";

export interface UseIntervalOptions {
/**
Expand All @@ -19,14 +19,15 @@ export interface UseIntervalOptions {
* @param options The options for the interval.
* @returns A function that clears the interval.
*/
export function useInterval(callback: () => void, delay?: number, options: UseIntervalOptions = {}) {
export function useInterval(callback: () => void, delay?: BindingOrValue<number>, options: UseIntervalOptions = {}) {
const { immediate = false } = options;

const callbackMemo = useLatestCallback(callback);
const cancel = useRef<() => void>();
const cancel = useRef<thread>();

const clear = useCallback(() => {
cancel.current?.();
if (!cancel.current) return;
task.cancel(cancel.current);
}, []);

useEffect(() => {
Expand All @@ -36,7 +37,13 @@ export function useInterval(callback: () => void, delay?: number, options: UseIn
if (immediate) {
callbackMemo();
}
cancel.current = setInterval(callbackMemo, delay);
cancel.current = task.spawn(() => {
// eslint-disable-next-line no-constant-condition
while (true) {
task.wait(getBindingValue(delay));
callbackMemo();
}
});
return clear;
}, [delay]);

Expand Down