Skip to content

feat: add Let's discuss button to post-outline plan approval#214

Merged
Nathan Schram (nathanschram) merged 2 commits intodevfrom
feature/discuss-button
Mar 23, 2026
Merged

feat: add Let's discuss button to post-outline plan approval#214
Nathan Schram (nathanschram) merged 2 commits intodevfrom
feature/discuss-button

Conversation

@nathanschram
Copy link
Member

Summary

  • Adds a "Let's discuss" button to the post-outline plan approval keyboard (between Approve Plan/Deny and cancel)
  • When clicked, tells Claude Code to ask the user what they'd like to discuss about the plan before deciding
  • New chat action in claude_control.py with _CHAT_DENY_MESSAGE
  • Handles both da: prefix (synthetic) and hold-open (real request_id) paths
  • Clears cooldown and outline_pending state on both paths
  • Post-outline keyboard now has 2 rows: [Approve Plan | Deny], [Let's discuss]

Test plan

  • 5 new tests added, 5 updated for new button layout
  • 1773 tests pass, 81% coverage
  • Ruff format + lint clean
  • Lockfile in sync

🤖 Generated with Claude Code

Add a 💬 Let's discuss button to the post-outline plan approval
buttons (between Approve Plan/Deny and cancel). When clicked, it
tells Claude Code to ask the user what they'd like to discuss about
the plan before deciding to approve or deny.

Implementation:
- New `chat` action in claude_control.py with `_CHAT_DENY_MESSAGE`
- Handles both da: prefix (synthetic) and hold-open (real request_id) paths
- Clears cooldown and outline_pending state on both paths
- Early toast: "Let's discuss..."
- Post-outline keyboard now has 2 rows: [Approve Plan | Deny], [Let's discuss]

Tests: 5 new tests, 5 updated for new button layout (1773 pass, 81% coverage)
Docs: updated 9 files across how-to, tutorial, reference, and rules

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2ea1634a-b3f3-43f1-bb55-f23e412f8a79

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/discuss-button

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nathanschram Nathan Schram (nathanschram) merged commit db94d8c into dev Mar 23, 2026
21 checks passed
@nathanschram Nathan Schram (nathanschram) deleted the feature/discuss-button branch March 23, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant