Skip to content

[WIP] WIP address feedback on DaySchedule and TimeSlot models #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Copilot wants to merge 1 commit into from
Closed

[WIP] WIP address feedback on DaySchedule and TimeSlot models #1266

Copilot wants to merge 1 commit into from

Conversation

Copy link
Contributor

Copilot AI commented Dec 2, 2025 •
edited
Loading

  • Understand the feedback: Add Final type annotation to MAX_TIME_SLOTS_PER_DAY constant
  • Update import statement in models.py to include Final from typing
  • Add Final[int] type annotation to MAX_TIME_SLOTS_PER_DAY declaration
  • Run pre-commit hooks to validate changes
  • Run code review

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Dec 2, 2025
Merged
@liudger liudger closed this Dec 2, 2025
Copilot AI requested a review from liudger December 2, 2025 07:48
@liudger liudger deleted the copilot/sub-pr-1265 branch December 2, 2025 14:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@liudger liudger Awaiting requested review from liudger

Assignees

@liudger liudger

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liudger