Fix null reference and subsystem ensure#6
Open
moonbusstudio wants to merge 3 commits intoliufei2008:LGUI3/5.5from
Open
Fix null reference and subsystem ensure#6moonbusstudio wants to merge 3 commits intoliufei2008:LGUI3/5.5from
moonbusstudio wants to merge 3 commits intoliufei2008:LGUI3/5.5from
Conversation
Check validity of TargetScriptArray[0] before dereferencing it in FLGUICanvasCustomization::GetDrawcallInfo. Also check world.
Fix the following ensure firing when exiting the editor: Ensure condition failed: !bInitialized [File:D:\build\++UE5\Sync\Engine\Source\Runtime\Engine\Private\Subsystems\WorldSubsystem.cpp] [Line: 115] Tickable subsystem LGUIManagerWorldSubsystem None.LGUIPrefabManagerObject_0:LGUI_PreviewWorldForPrefabPackage_0.None was destroyed while still initialized! Check for missing Super call Don't create the preview world for prefab package from calls to GetPreviewWorldForPrefabPackage that are just checking UWorld equality in order to skip the preview world. Also don't create the FLGUIObjectCreateDeleteListener, since it has no purpose with ULGUIPrefabHelperObject::OnComponentCreateDelete disabled (not related to the ensure). Also don't override ULGUIPrefabWorldSubsystem::Initialize and ULGUIPrefabWorldSubsystem::Deinitialize without calling Super (also not related to the ensure, but seems unwise).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a null reference in the editor, and fix a Tickable Subsystem ensure firing when exiting the editor.