Content length should be based on the byte size of the content#1
Open
ikari7789 wants to merge 1 commit intolivedoor:masterfrom
ikari7789:master
Open
Content length should be based on the byte size of the content#1ikari7789 wants to merge 1 commit intolivedoor:masterfrom ikari7789:master
ikari7789 wants to merge 1 commit intolivedoor:masterfrom
ikari7789:master
Conversation
… than the string length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content length should be based on the byte size of the content rather than the string length. When working with UTF-8 data stored in hex notation in $content, length reads the hex values as a single character rather than the full length creating a malformed HTTP response.
For example:
$content = "\x{0100}"
length $content = 1
bytes $content = 8