Handle DateTime fields through Repo#81
Open
mangr3n wants to merge 2 commits intoliveforeverx:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if I did this the right way, but as is the Repo.set and Repo.get functions were not handling :datetime attributes
The first change was to use an Ecto.Type that exists. :utc_datetime is the Ecto type that matches.
Dgraph encodes datetime attributes as rfc3339. I did not find a native rfc3339 parsing/formatting library so I brought int Calendar 1.0
Finally, I modified decoding and encoding fields to turn DateTime structs into rfc3339 strings and :utc_datetime rfc3339 strings into DateTime structs
I need these changes to continue to move forward using this library in my project.