Media Devices #493
Open
Media Devices #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theomonnom
reviewed
Sep 29, 2025
| except StopAsyncIteration: | ||
| exhausted = True | ||
| break | ||
| # AudioStream may yield either AudioFrame or AudioFrameEvent; unwrap if needed |
There was a problem hiding this comment.
The correct typing should be:
self, stream: AsyncIterator[AudioFrame | AudioFrameEvent], buf: np.ndarray
| stream_kwargs["mapping"] = mapping | ||
| elif mapping is not None: | ||
| logging.getLogger(__name__).warning( | ||
| "sounddevice.InputStream does not support 'mapping' in this version; " |
There was a problem hiding this comment.
Do we have to support that? or only latest?
| input_channel_index, | ||
| ) | ||
|
|
||
| input_stream = sd.InputStream(**stream_kwargs) |
There was a problem hiding this comment.
nit: Ideally we keep the typed args (no dict)
| participant: rtc.RemoteParticipant, | ||
| ): | ||
| if track.kind == rtc.TrackKind.KIND_AUDIO: | ||
| stream = rtc.AudioStream(track, sample_rate=48000, num_channels=1) |
There was a problem hiding this comment.
I think we should abstract further down, and directly allow to add a AudioTrack
There was a problem hiding this comment.
do you mean we should add a add_track and remove_track method to the AudioMixer class?
| def open_output( | ||
| self, | ||
| *, | ||
| apm_for_reverse: Optional[AudioProcessingModule] = None, |
There was a problem hiding this comment.
This should be exposed to the user. Let's make this an internal detail
There was a problem hiding this comment.
do you mean should not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediaDevicesthat provides centralized access to local audio input/outputs.