Skip to content

Models docker not to be compressed #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pwilczynskiclearcode wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Models docker not to be compressed #519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ai-runner-models.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ jobs:
file: runner/docker/Dockerfile.models
cache-from: type=registry,ref=livepeerci/ai-runner-models:dockerbuildcache-batch
cache-to: type=registry,ref=livepeerci/ai-runner-models:dockerbuildcache-batch,mode=max
outputs: type=image,compression=uncompressed,force-compression=true,compression-level=0,push=true

download_build_tensorrt_models:
strategy:
Expand Down Expand Up @@ -159,8 +160,9 @@ jobs:
with:
context: .
platforms: linux/amd64
push: ${{ github.event_name != 'pull_request' }}
push: true
Copy link

Copilot AI Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unconditionally setting 'push' to true may lead to images being pushed on pull request events. Please verify that this behavior is intended to avoid unintended deployments.

Suggested change
push: true
push: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}

Copilot uses AI. Check for mistakes.
tags: ${{ steps.meta.outputs.tags }}
file: runner/docker/Dockerfile.models
cache-from: type=registry,ref=livepeerci/ai-runner-models:dockerbuildcache-tensorrt-${{ matrix.gpu }}
cache-to: type=registry,ref=livepeerci/ai-runner-models:dockerbuildcache-tensorrt-${{ matrix.gpu }},mode=max
outputs: type=image,compression=uncompressed,force-compression=true,compression-level=0,push=true