Fix:streamdiffusion custom node build, dependencies conflict issue#579
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| # Add new nodes as needed. | ||
|
|
||
| streamdiffusion: | ||
| script: /workspace/ComfyUI/custom_nodes/ComfyUI-StreamDiffusion/scripts/build_tensorrt_engines.py |
There was a problem hiding this comment.
This is neat, does it support arguments for other scripts like build_trt.py?
We will need to cover the case when an image is built using nodes.yaml, and entrypoint.sh is ran with --build-engines, Just need a basic check to not attempt build if the custom nodes folder or script doesn't exist.
There was a problem hiding this comment.
We can finalize that in #488 though, will go ahead and merge this one
There was a problem hiding this comment.
Can cherry-pick this one to guard the other engine builds or refactor to your script
There was a problem hiding this comment.
This is neat, does it support arguments for other scripts like build_trt.py?
We will need to cover the case when an image is built using nodes.yaml, and entrypoint.sh is ran with
--build-engines, Just need a basic check to not attempt build if the custom nodes folder or script doesn't exist.
The [entrypoint.sh]already checks for the existence of build_targets.yaml, the required folder, and the script before attempting StreamDiffusion engine builds (see lines 142–144 and the Python block around line 150+). It skips the build if any are missing, just like the new logic for other nodes which you referred for cherry picking.
2 participants
Changes made on top of PR #488