ai/live: Read JSONL from a time delimited data channel.#3706
Draft
ai/live: Read JSONL from a time delimited data channel.#3706
Conversation
This allows us to stream segments from one in-memory location to another. New reads will always start at the beginning of the current segment. Also make the original MediaWriter follow io.WriteCloser
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3706 +/- ##
===================================================
- Coverage 31.68826% 31.58963% -0.09863%
===================================================
Files 158 158
Lines 47617 47791 +174
===================================================
+ Hits 15089 15097 +8
- Misses 31632 31798 +166
Partials 896 896
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #3705 and #3689
Two missing pieces: