Skip to content

Conversation

@j0sh
Copy link
Collaborator

@j0sh j0sh commented Sep 5, 2025

Needed to fix livepeer/lpms#438

The go mod tidy step reshuffled a few dependencies and cleaned up go.sum but no other version bumps.

Needed to fix livepeer/lpms#438

The `go mod tidy` step reshuffled a few dependencies and cleaned
up go.sum but no other version bumps.
@j0sh j0sh requested a review from thomshutt September 5, 2025 15:28
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Sep 5, 2025
@j0sh j0sh requested review from leszko, mjh1 and victorges September 5, 2025 15:28
@ad-astra-video ad-astra-video self-requested a review September 5, 2025 15:35
Copy link
Collaborator

@ad-astra-video ad-astra-video left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added myself as a reviewer reqeustd. Approved.

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.65288%. Comparing base (528ca2b) to head (7e46e45).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3734         +/-   ##
===================================================
- Coverage   31.65564%   31.65288%   -0.00276%     
===================================================
  Files            158         158                 
  Lines          47764       47765          +1     
===================================================
- Hits           15120       15119          -1     
- Misses         31743       31744          +1     
- Partials         901         902          +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29fd2d...7e46e45. Read the comment docs.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rickstaa rickstaa self-requested a review September 5, 2025 15:54
@j0sh j0sh enabled auto-merge (squash) September 5, 2025 16:02
@rickstaa
Copy link
Member

rickstaa commented Sep 5, 2025

@j0sh builds, test pass, offchain manual stream tests succesfull. As a result, I would be comfortable shipping this.

@j0sh j0sh merged commit 05fbfc1 into master Sep 5, 2025
16 checks passed
@j0sh j0sh deleted the ja/lpms-438 branch September 5, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants